Changeset 1315

Timestamp:

01/22/08 18:02:18 (7 months ago)

Author:

bjornroche

Message:

some assertion cleanup

Files:

• portaudio/branches/v19-devel/src/hostapi/coreaudio/pa_mac_core.c (modified) (3 diffs)

portaudio/branches/v19-devel/src/hostapi/coreaudio/pa_mac_core.c

@@ -129 +129 @@
    err = PaUtil_GetHostApiRepresentation( &hostApi, paCoreAudio );
    assert(err == paNoError);
+   if( err != paNoError )
+      return NULL;
    PaMacAUHAL *macCoreHostApi = (PaMacAUHAL*)hostApi;
    AudioDeviceID hostApiDevice = macCoreHostApi->devIds[device];
@@ -318 +320 @@
    err = AudioUnitGetProperty( ci, kAudioOutputUnitProperty_IsRunning, inScope, inElement, &isRunning, &size );
    assert( !err );
+   if( err )
+      isRunning = false; //it's very unclear what to do in case of error here. There's no real way to notify the user, and crashing seems unreasonable.
    if( isRunning )
       return; //We are only interested in when we are stopping
@@ -1829 +1833 @@
                     inNumberFrames,
                     &stream->inputAudioBufferList );
-      /* FEEDBACK: I'm not sure what to do when this call fails */
+      /* FEEDBACK: I'm not sure what to do when this call fails. There's nothing in the PA API to
+       * do about failures in the callback system. */
       assert( !err );